Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging pull requests #40 and #31 #43

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

anteldan
Copy link

@anteldan anteldan commented Jan 8, 2018

Merged my new menu

View / Show card short id

with native electron menu from lenn4rd pull request #31

Removed trailing white spaces on some lines and making a correct commit title.
Introducing a new "View" menu and its checkbox item "Show card short id".
All trello cards have a "short id" in a span element, which is hidden. CSS class is ".card-short-id hide".
Checking/unchecking "Show card short id" will page.insertCSS a new class ".card-short-id.hide" definition "display: inline-flex; padding-right: .3em;" or "display: none;"
Checkbox state is saved in config.
I never developped with electron, so sorry if page.insertCSS is not the right way and please enhance the code !
Merged pull request danielchatfield#31 to add native Electron menu
Removed .header-boards-button class definition in order to remove left margin in #header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant